Fix rendering of exported SVG #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace invalid characters in attribute value; fixes the error
Unescaped '<' not allowed in attributes values
rndstr
force-pushed
the
2534-replace-invalid-id-characters
branch
from
8fabeaf to
998f92b
Compare
|
@rade thanks for confirming (the comment that reported it was by @pidster #2531 (comment)) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace invalid characters in attribute value; fixes the error
Fixes #2534
There are a bunch of other errors when validating the SVG but renderers might be okay with these
@pidster would you mind opening the following SVG file in the browser where you get the other error and see whether it works now? weave-cloud-1501839338756.svg.zip